VolumeCreateFromSnapshot and SetTags for FCD volume implementation #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakanmemisoglu
changed the title
added 2 commits
October 10, 2019 13:56
tdmanv
approved these changes
Oct 10, 2019
| } | ||
| _, err = task.Wait(ctx, defaultWaitTime) | ||
| if err != nil { | ||
| return errors.Wrap(err, "Failed to wait on task") |
There was a problem hiding this comment.
[minor] this method will return nil if err == nil. You don't need to check the error, you can just directly return return errors.Wrap(err, "Failed to wait on task")
| @@ -115,7 +143,7 @@ func (p *fcdProvider) SnapshotCreate(ctx context.Context, volume blockstorage.Vo | |||
| } | |||
|
|
|||
| func (p *fcdProvider) SnapshotCreateWaitForCompletion(ctx context.Context, snapshot *blockstorage.Snapshot) error { | |||
| return errors.New("Not implemented") | |||
| return nil | |||
There was a problem hiding this comment.
What's the reason for making this a noop?
There was a problem hiding this comment.
SnapshotCreate will block until the snapshot is ready. That's why I decided to make it a noop.
|
@tdmanv It got merged before making the fixes. I will do it next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds:
Pull request type
Please check the type of change your PR introduces: