Render all output artifacts #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkamra
approved these changes
Oct 11, 2019
vkamra
reviewed
Oct 11, 2019
| @@ -92,13 +92,21 @@ func describeBackupsPodFunc(cli kubernetes.Interface, tp param.TemplateParams, n | |||
| break | |||
| case strings.Contains(err.Error(), restic.PasswordIncorrect): | |||
| return map[string]interface{}{ | |||
| DescribeBackupsSnapshotIDs: nil, | |||
There was a problem hiding this comment.
Can we updated the unit test in data_test.go to catch this issue please?
There was a problem hiding this comment.
In data_test we only runAction, so this was not caught.
When I ran this action against a cluster, it failed like this:
time="2019-10-11T03:38:26Z" level=info msg="Completed phase describeBackupsForRepo"
time="2019-10-11T03:38:26Z" level=error msg="Failed to render output artifacts template: config:1:10: executing \"config\" at <.Phases.describeBackupsForRepo.Output.fileCount>: map has no entry for key \"fileCount\"\nvendor/github.com/kanisterio/kanister/pkg/param.renderStringArg\n\t/root/src/github.com/kastenhq/k10/go/src/vendor/github.com/kanisterio/kanister/pkg/param/render.go:115\nvendor/github.com/kanisterio/kanister/pkg/param.RenderArtifacts\n\t/root/src/github.com/kastenhq/k10/go/src/vendor/github.com/kanisterio/kanister/pkg/param/render.go:94\nvendor/github.com/kanisterio/kanister/pkg/controller.(*Controller).runAction.func1\n\t/root/src/github.com/kastenhq/k10/go/src/vendor/github.com/kanisterio/kanister/pkg/controller/controller.go:447\nvendor/gopkg.in/tomb%2ev2.(*Tomb).run\n\t/root/src/github.com/kastenhq/k10/go/src/vendor/gopkg.in/tomb.v2/tomb.go:163\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1337"
time="2019-10-11T03:38:26Z" level=info msg="Updated ActionSet 'k10-describe-k10-dr-bp-8jn57-catalog-svc-kasten-io-deploympbtsp' Status->failed"
We need controller level tests to catch this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
actionSetfails if all output artifacts are not specifiedPull request type
Please check the type of change your PR introduces:
Test Plan