Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output rendering #353

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Fix output rendering #353

merged 3 commits into from
Oct 11, 2019

Conversation

DeepikaDixit
Copy link
Contributor

Change Overview

actionSet fails if all output artifacts are not specified

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trivial/Minor
  • Bugfix
  • Feature
  • Documentation

Issues

  • #XXX

Test Plan

  • Manual
  • Unit test
  • E2E

@DeepikaDixit
Copy link
Contributor Author

New error when output set to nil:

time="2019-10-11T05:28:38Z" level=error msg="Failed to render output artifacts template: config:1: unexpected \"}\" in operand\nvendor/github.com/kanisterio/kanister/pkg/param.renderStringArg\n\t/repo/go/src/vendor/github.com/kanisterio/kanister/pkg/param/render.go:111\nvendor/github.com/kanisterio/kanister/pkg/param.RenderArtifacts\n\t/repo/go/src/vendor/github.com/kanisterio/kanister/pkg/param/render.go:94\nvendor/github.com/kanisterio/kanister/pkg/controller.(*Controller).runAction.func1\n\t/repo/go/src/vendor/github.com/kanisterio/kanister/pkg/controller/controller.go:447\nvendor/gopkg.in/tomb%2ev2.(*Tomb).run\n\t/repo/go/src/vendor/gopkg.in/tomb.v2/tomb.go:163\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1337"

@DeepikaDixit
Copy link
Contributor Author

New error when output set to nil:

time="2019-10-11T05:28:38Z" level=error msg="Failed to render output artifacts template: config:1: unexpected \"}\" in operand\nvendor/github.com/kanisterio/kanister/pkg/param.renderStringArg\n\t/repo/go/src/vendor/github.com/kanisterio/kanister/pkg/param/render.go:111\nvendor/github.com/kanisterio/kanister/pkg/param.RenderArtifacts\n\t/repo/go/src/vendor/github.com/kanisterio/kanister/pkg/param/render.go:94\nvendor/github.com/kanisterio/kanister/pkg/controller.(*Controller).runAction.func1\n\t/repo/go/src/vendor/github.com/kanisterio/kanister/pkg/controller/controller.go:447\nvendor/gopkg.in/tomb%2ev2.(*Tomb).run\n\t/repo/go/src/vendor/gopkg.in/tomb.v2/tomb.go:163\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1337"

This is blueprint error 🤦‍♀

DeepikaDixit
DeepikaDixit commented Oct 11, 2019
View reviewed changes
pkg/function/describe_backups.go
@@ -106,7 +106,7 @@ func describeBackupsPodFunc(cli kubernetes.Interface, tp param.TemplateParams, n
DescribeBackupsFileCount: nil,
DescribeBackupsSize: nil,
DescribeBackupsPasswordIncorrect: nil,
DescribeBackupsRepoDoesNotExist: "false",
DescribeBackupsRepoDoesNotExist: "true",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my bad. It needs to return true, previous PR made it false.

@mergify mergify bot merged commit b33a7ae into master Oct 11, 2019
@mergify mergify bot deleted the fix-output-render branch October 11, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkamra vkamra vkamra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DeepikaDixit @vkamra