Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields to log.print() func #360

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Add fields to log.print() func #360

merged 2 commits into from
Oct 15, 2019

Conversation

SupriyaKasten
Copy link
Contributor

Change Overview

Add fields to log.print()

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trivial/Minor
  • Bugfix
  • Feature
  • Documentation

Issues

  • #XXX

Test Plan

go test
OK: 8 passed
PASS
ok  	github.com/kanisterio/kanister/pkg/log	0.008s
  • Manual
  • Unit test
  • E2E

@mergify mergify bot merged commit a58994c into master Oct 15, 2019
@mergify mergify bot deleted the log-print branch October 15, 2019 22:01
@julio-lopez
Copy link
Contributor

LG +1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdmanv tdmanv tdmanv approved these changes

@julio-lopez julio-lopez Awaiting requested review from julio-lopez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SupriyaKasten @julio-lopez @tdmanv