Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor the "image" argument in RestoreData and RestoreDataAll functions #363

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Honor the "image" argument in RestoreData and RestoreDataAll functions #363

merged 1 commit into from
Oct 16, 2019

Conversation

pavannd1
Copy link
Contributor

Change Overview

  • The above two functions use kanisterToolsImage implicitly instead of using the image input argument from the blueprint.
  • This PR honors the passed in image argument.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@mergify mergify bot merged commit 51a945f into master Oct 16, 2019
@mergify mergify bot deleted the rst_image branch October 16, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdmanv tdmanv tdmanv approved these changes

@SupriyaKasten SupriyaKasten Awaiting requested review from SupriyaKasten

@DeepikaDixit DeepikaDixit Awaiting requested review from DeepikaDixit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavannd1 @tdmanv