-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with BackupStats #364
Conversation
docs/functions.rst
Outdated
mode: "{{ .Phases.backupDataStatsFromObjectStore.Output.BackupDataStatsOutputMode }}" | ||
fileCount "{{ .Phases.backupDataStatsFromObjectStore.Output.BackupDataStatsOutputFileCount }}" | ||
size: "{{ .Phases.backupDataStatsFromObjectStore.Output.BackupDataStatsOutputSize }}" | ||
mode: "{{ .Phases.BackupDataStatsFromObjectStore.Output.BackupDataStatsOutputMode }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we add mode to Output
? Is this where it would be: https://github.com/kanisterio/kanister/blob/master/pkg/function/describe_backups.go#L94 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in BackupStats
kanister/pkg/function/backup_data_stats.go
Line 100 in 1f79078
BackupDataStatsOutputMode: mode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, this is the correct function: https://github.com/kanisterio/kanister/blob/master/pkg/function/backup_data_stats.go#L100.
Should the output keys be lowercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing both cases in this file. Not sure which is better/correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower case is better. Updating..
Change Overview
Update docs
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan