Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test framework #366

Merged
merged 5 commits into from
Nov 11, 2019
Merged

Integration test framework #366

merged 5 commits into from
Nov 11, 2019

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Oct 17, 2019

Change Overview

  • Add helper methods in pkg/testutils to create Profile based on cred set as env vars
  • Export kanctl helper methods for integration tests
  • Add postgres rds integration test
  • Add new make rule "make integration-test"
  • Add support for AWS_SESSION_TOKEN in postgres test

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@PrasadG193 PrasadG193 force-pushed the e2e-tests branch 3 times, most recently from d2f17de to e47a06f Compare October 22, 2019 12:49
@PrasadG193 PrasadG193 changed the title E2E test framework Integration test framework Oct 22, 2019
@SupriyaKasten
Copy link
Contributor

@PrasadG193, I discussed your concerns with @tdmanv.
Regarding the func GetEnvOrSkip(c *check.C, varName string), we will have to modify the test interface in order to provide the c param and skip the test early, during setup, if the env variables are not set.

Regarding how to set up env variable in container: @tdmanv will discuss more about it in the next meeting. for now, you can assume that the env variable are set and move ahead accordingly. We are planning to run a new job in addition to the travis CI, to run these integration tests. more discussion will be done over the meeting. Lets make sure that the tests pass locally for you and please include the result of the test in the PR commit.

@PrasadG193
Copy link
Contributor Author

@SupriyaKasten I've modified interfaces to pass check object and used that in error checking.
About test results, do we want to include the verbose output in the commit? Because it is too long (around 300 lines) for Postgres test. I am not sure if that would a good idea.

@PrasadG193 PrasadG193 marked this pull request as ready for review October 23, 2019 10:10
@PrasadG193
Copy link
Contributor Author

PrasadG193 commented Oct 24, 2019

E2E integration test verbose logs
Command: go test -v ./pkg/testing -tags=integration -timeout 30m
logs: https://gist.github.com/PrasadG193/3aa12a9d8fbd5febf323636cc365c4ce

Export kanctl helper methods for integration tests

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Add new make rule "make integration-test"

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Validate Blueprint with app object references

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@mergify mergify bot merged commit 5b06ff1 into kanisterio:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants