Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding backup stats to copy function #370

Merged
merged 3 commits into from
Oct 19, 2019
Merged

Adding backup stats to copy function #370

merged 3 commits into from
Oct 19, 2019

Conversation

redgoat650
Copy link
Contributor

Change Overview

Adding size and file count outputs to Copy Volume function and changing backup stats output keys to be defined as their own named keys.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@redgoat650 redgoat650 changed the title Stash conflicts Adding backup stats to copy function Oct 19, 2019
DeepikaDixit
DeepikaDixit approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@DeepikaDixit DeepikaDixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit cf8b227 into master Oct 19, 2019
@mergify mergify bot deleted the size-from-copy branch October 19, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepikaDixit DeepikaDixit DeepikaDixit approved these changes

@vkamra vkamra Awaiting requested review from vkamra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@redgoat650 @DeepikaDixit