Dynamic registration of Kanister functions with multiple versions #371

pavannd1 · 2019-10-22T21:41:59Z

Change Overview

The PR can be reviewed commit wise.

Register multiple functions with different versions
Select appropriate version during execution of an ActionSet using Version supplied
Add unit tests to verify registration of multiple functions, fall back mechanism, no version specified in ActionSet as well as no version found.
Minor changes to signatures in existing tests

Please check the type of change your PR introduces:

tdmanv

Looks good though I'm not sure this is safe to merge if a version is not specified

pkg/phase.go

pkg/controller/controller.go

Pavan Navarathna Devaraj added 3 commits October 22, 2019 14:36

Changes to register functions with versions

58e4c6c

Add unit test

a9e648e

Func signature changes in tests

b916690

pavannd1 requested review from tdmanv, vkamra and SupriyaKasten October 22, 2019 21:42

Add version to actionsets in e2e tests

ff9852b

tdmanv reviewed Oct 22, 2019

View reviewed changes

pkg/phase.go Outdated Show resolved Hide resolved

pkg/controller/controller.go Show resolved Hide resolved

Address review comments and add more unit tests

9d92196

pavannd1 requested a review from tdmanv October 24, 2019 01:27

SupriyaKasten added the hold off merging label Oct 24, 2019

pavannd1 removed the hold off merging label Oct 25, 2019

pavannd1 requested a review from julio-lopez October 25, 2019 00:56

tdmanv approved these changes Oct 25, 2019

View reviewed changes

Merge branch 'master' into func_version

04e5e20

mergify bot merged commit 0f922ac into master Oct 25, 2019

mergify bot deleted the func_version branch October 25, 2019 18:55