Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor function helpers into one file and export them #374

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Refactor function helpers into one file and export them #374

merged 1 commit into from
Oct 29, 2019

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented Oct 28, 2019 •
edited

Change Overview

  • Moving some helper functions into a single file and exporting them.
  • The functions can be reused outside the package when necessary.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@pavannd1 pavannd1 changed the title Refactor function helpers into one file Refactor function helpers into one file and export them Oct 28, 2019
DeepikaDixit
DeepikaDixit reviewed Oct 28, 2019
View reviewed changes
Copy link
Contributor

@DeepikaDixit DeepikaDixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let @tdmanv approve

@pavannd1
Copy link
Contributor Author

@SupriyaKasten Please take a look at this when you find time.

@SupriyaKasten
Copy link
Contributor

@SupriyaKasten Please take a look at this when you find time.

Looks good to me @pavannd1 🚀 :shipit:

@mergify mergify bot merged commit 673f595 into master Oct 29, 2019
@mergify mergify bot deleted the refactor1 branch October 29, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepikaDixit DeepikaDixit DeepikaDixit left review comments

@SupriyaKasten SupriyaKasten SupriyaKasten approved these changes

@tdmanv tdmanv Awaiting requested review from tdmanv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pavannd1 @SupriyaKasten @DeepikaDixit