Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Move required constant out of restic package #375

Merged
merged 1 commit into from
Oct 29, 2019
Merged

[Minor] Move required constant out of restic package #375

merged 1 commit into from
Oct 29, 2019

Conversation

pavannd1
Copy link
Contributor

Change Overview

  • This one is used in multiple packages and leads to dependency on restic package.
  • Using the existing consts pkg makes it cleaner.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@pavannd1 pavannd1 changed the title Move required constant out of restic package [Minor] Move required constant out of restic package Oct 29, 2019
@mergify mergify bot merged commit f15eb57 into master Oct 29, 2019
@mergify mergify bot deleted the refactor2 branch October 29, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupriyaKasten SupriyaKasten SupriyaKasten approved these changes

@DeepikaDixit DeepikaDixit Awaiting requested review from DeepikaDixit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavannd1 @SupriyaKasten