Modify describe to not list snapshots #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepikaDixit
commented
Oct 31, 2019
| @@ -255,9 +266,7 @@ func resticAzureArgs(profile *param.Profile, repository string) []string { | |||
|
|
|||
| // GetOrCreateRepository will check if the repository already exists and initialize one if not | |||
| func GetOrCreateRepository(cli kubernetes.Interface, namespace, pod, container, artifactPrefix, encryptionKey string, profile *param.Profile) error { | |||
| stdout, stderr, err := listSnapshots(profile, artifactPrefix, encryptionKey, cli, namespace, pod, container) | |||
| format.Log(pod, container, stdout) | |||
There was a problem hiding this comment.
We don't need to print the output. That will help reduce the long logs
There was a problem hiding this comment.
It is already printed in getLatestSnapshots
DeepikaDixit
changed the title
DeepikaDixit
changed the title
tdmanv
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Listing snapshots is an
expensiveoperation. Also, we do not need a list of snapshots.Changing the command to check for latest instead
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan