Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CheckRepository func #382

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Add a CheckRepository func #382

merged 4 commits into from
Nov 6, 2019

Conversation

DeepikaDixit
Copy link
Contributor

@DeepikaDixit DeepikaDixit commented Nov 4, 2019 •
edited

Change Overview

Add a checkRepository func that checks repo is present and password is correct

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

None filed

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

pavannd1
pavannd1 reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 👍

tdmanv
tdmanv reviewed Nov 5, 2019
View reviewed changes
pkg/function/checkRepository.go Show resolved Hide resolved
pkg/function/checkRepository.go Outdated Show resolved Hide resolved
pkg/function/checkRepository.go Outdated Show resolved Hide resolved
pkg/function/checkRepository.go Outdated Show resolved Hide resolved
pkg/function/data_test.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit d80360a into master Nov 6, 2019
@mergify mergify bot deleted the checkRepo-func branch November 6, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@vkamra vkamra Awaiting requested review from vkamra

@tdmanv tdmanv Awaiting requested review from tdmanv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DeepikaDixit @tdmanv @pavannd1