Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dereference of optional deletion policy field #387

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fix dereference of optional deletion policy field #387

merged 1 commit into from
Nov 7, 2019

Conversation

vkamra
Copy link

@vkamra vkamra commented Nov 7, 2019

Change Overview

The DeletionPolicy field in a VolumeStorageClass is optional and should not be
dereferenced without a nil check. This fixes that.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

@vkamra vkamra requested a review from pavannd1 November 7, 2019 00:48
@mergify mergify bot merged commit bc128b1 into master Nov 7, 2019
@mergify mergify bot deleted the fix_deref branch November 7, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vkamra @pavannd1