Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[392] Add constants to define function names #394

Merged
merged 1 commit into from
Nov 8, 2019
Merged

[392] Add constants to define function names #394

merged 1 commit into from
Nov 8, 2019

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented Nov 8, 2019

Change Overview

  • Adding constants to avoid typos and bugs while using strings to define function names in Go source code.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

DeepikaDixit
DeepikaDixit approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@DeepikaDixit DeepikaDixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mergify mergify bot merged commit 4b0a0a4 into master Nov 8, 2019
@mergify mergify bot deleted the refactor5 branch November 8, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepikaDixit DeepikaDixit DeepikaDixit approved these changes

@tdmanv tdmanv Awaiting requested review from tdmanv

@SupriyaKasten SupriyaKasten Awaiting requested review from SupriyaKasten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavannd1 @DeepikaDixit