Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly install npm in elastic image #396

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Explicitly install npm in elastic image #396

merged 1 commit into from
Nov 11, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Nov 11, 2019

Change Overview

Should fix the following:

/esdump-setup.sh: line 5: npm: not found
/esdump-setup.sh: line 7: npm: not found
/usr/bin/node
v10.16.3
/esdump-setup.sh: line 13: npm: not found
/esdump-setup.sh: line 14: npm: not found
/esdump-setup.sh: line 15: npm: not found
The command '/bin/sh -c chmod +x /esdump-setup.sh && sync && /esdump-setup.sh' returned a non-zero code: 127
: exit status 127
make[1]: *** [run] Error 1
make: *** [gorelease] Error 2

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

We should test building the image prior to merging.

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@mergify mergify bot merged commit d84428b into master Nov 11, 2019
@mergify mergify bot deleted the es-apk-npm branch November 11, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants