Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for foundationdb in integration test suite #467

Merged
merged 9 commits into from
Jan 3, 2020
Merged

Add support for foundationdb in integration test suite #467

merged 9 commits into from
Jan 3, 2020

Conversation

viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Dec 26, 2019 •
edited
Loading

Change Overview

This change adds foundationdb in our integration test suite.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

To test the foundationdb we can use below command

make integration-test

The logs can be found at this gist.

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@viveksinghggits viveksinghggits force-pushed the integration-fdb branch 3 times, most recently from 8046968 to ddff09a Compare December 26, 2019 16:32
tdmanv
tdmanv approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@tdmanv tdmanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! Please include the output when running the test in the PR description

tdmanv
tdmanv reviewed Dec 31, 2019
View reviewed changes
go.sum Outdated Show resolved Hide resolved
@viveksinghggits
Copy link
Contributor Author

this looks great! Please include the output when running the test in the PR description

Hi @tdmanv
I actually mentioned the link to the log of the test. that is in a secret gist.

@tdmanv tdmanv mentioned this pull request Dec 31, 2019
Closed
@mergify mergify bot merged commit 177b126 into kanisterio:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdmanv tdmanv tdmanv approved these changes

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@vkamra vkamra Awaiting requested review from vkamra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viveksinghggits @tdmanv @PrasadG193