Update RDS app and README to work with RDS functions #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
vkamra
reviewed
Jan 20, 2020
| actionset backup-llfb8 created | ||
|
|
||
| # Where, | ||
| # dbconfig is a configmap holding RDS infromation |
There was a problem hiding this comment.
Suggested change
| # dbconfig is a configmap holding RDS infromation | |
| # dbconfig is a configmap that contains information on the RDS instance to be protected |
vkamra
reviewed
Jan 20, 2020
| dbName, ok := os.LookupEnv(pgDBEnv) | ||
| if !ok { | ||
| return nil, fmt.Errorf("%s environment variable not set", pgDBEnv) | ||
| } | ||
| // Parse databases from config data | ||
| var databases []string |
vkamra
approved these changes
Jan 20, 2020
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
force-pushed
the
update-rds-readme
branch
from
13cb20e
to
b1d2058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan