Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another way to install databases on openshift cluster #570

Merged
merged 4 commits into from
Feb 21, 2020

Conversation

viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Feb 19, 2020

Change Overview

Openshift team suggested some standard ways to install database on openshift cluster. This PR implements that way to and have respective change in the mysql app that we deployed on the openshift cluster.

https://github.com/openshift/origin/tree/master/examples/db-templates

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

You will first have to setup minishift cluster using

make start-minishift vm-driver=<driver>

after that run

# make sure to run only the apps that are to be deployed on openshift cluster
make integration-test
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

pkg/app/utils.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 7ca06d7 into kanisterio:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants