Support to have OpenShift apps ephemeral or persistent #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Mar 3, 2020
viveksinghggits
force-pushed
the
os-apps-storage-fix
branch
from
defbdb4
to
c7dff7b
Compare
PrasadG193
reviewed
Mar 4, 2020
PrasadG193
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
In current implementation if we deployed OpenShift apps as part of test, the apps were persistent always this change adds the support to have epehmeral apps as well.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Run
to test the things, make sure you have setup a minishift cluster using command
Logs of this test can be found here