Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move controller logic into a separate package #709

Merged
merged 5 commits into from
Jun 22, 2020
Merged

Move controller logic into a separate package #709

merged 5 commits into from
Jun 22, 2020

Conversation

miquella
Copy link
Contributor

Change Overview

Split the controller logic into a separate package, just like kanctl and kando.

Pull request type

Please check the type of change your PR introduces:

  • 🐹 Trivial/Minor

Issues

  • N/A

Test Plan

Manually compiled and tested locally.

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@miquella miquella requested a review from tdmanv June 22, 2020 17:13
@miquella miquella requested a review from pavannd1 June 22, 2020 17:34
ewhamilton
ewhamilton reviewed Jun 22, 2020
View reviewed changes
cmd/controller/main.go Outdated Show resolved Hide resolved
@miquella miquella requested a review from ewhamilton June 22, 2020 17:54
@miquella miquella added the kueue label Jun 22, 2020
@mergify mergify bot merged commit 6e56908 into master Jun 22, 2020
@mergify mergify bot deleted the split-controller-logic branch June 22, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@tdmanv tdmanv Awaiting requested review from tdmanv

@ewhamilton ewhamilton Awaiting requested review from ewhamilton

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miquella @pavannd1 @ewhamilton