Use namespace as subject instead of etcd pod for k8s etcd backup and restore #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksinghggits
force-pushed
the
k8s-etcd-ns-annotate
branch
from
42478f9
to
f6b0639
Compare
PrasadG193
reviewed
Aug 27, 2020
pavannd1
reviewed
Aug 27, 2020
PrasadG193
approved these changes
Aug 27, 2020
pavannd1
reviewed
Aug 27, 2020
examples/etcd/etcd-in-cluster/k8s/etcd-incluster-blueprint.yaml
Outdated
Show resolved
Hide resolved
examples/etcd/etcd-in-cluster/k8s/etcd-incluster-blueprint.yaml
Outdated
Show resolved
Hide resolved
| @@ -139,7 +139,8 @@ No resources found. | |||
|
|
|||
| To restore the ETCD cluster we can follow the [documentation](https://docs.openshift.com/container-platform/4.5/backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state.html) that is provided by the OpenShift team. | |||
| But we will have to make some modification in the restore script (`cluster-restore.sh`) because default | |||
| restore script expects the static pods manifest as well, and in our case we didn't backup the static pod manifests. | |||
| restore script expects the static pods manifest as well, and in our case we didn't backup the static pod manifests. We have made respective changes | |||
| in the script that is provided by OpenShift, that can be found in this repo. | |||
|
|
|||
| You can follow the steps that are mentioned below along with the documentation that is mentioned above, most of the steps that are mentioned here are either directly taken from the documentation or are modified version of it. Among all the running leader nodes choose one node to be the restore node, make sure you have SSH connectivity to all of the leader nodes including the one that you have chosen to be restore node. | |||
There was a problem hiding this comment.
Suggested change
| You can follow the steps that are mentioned below along with the documentation that is mentioned above, most of the steps that are mentioned here are either directly taken from the documentation or are modified version of it. Among all the running leader nodes choose one node to be the restore node, make sure you have SSH connectivity to all of the leader nodes including the one that you have chosen to be restore node. | |
| Additional steps to be followed are mentioned below. Among all the running leader nodes, choose one node to be the restore node. Ensure there is SSH connectivity to all the leader nodes including the one the chosen restore node. |
There was a problem hiding this comment.
so I wanted to clearly specify that the steps that are mentioned below are not our steps (steps that we have figured) but they have just been taken from the above documentation. And I think that is an important distinction to make. WDYT
There was a problem hiding this comment.
Hi @tdmanv
Can you please have a look into above comment. And suggest what should be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Per current blueprint we were using etcd pod as subject, which would result in issues because of static pods. This PR changes that to have namespace as subject.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan