Minor improvement in the bump version script #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is not ideal, there are chances that some files that we dont know of have these versions now we just ignore mod,bin dirs and binary files and running the script on the entire K10 repo. We already introduced the issue by not running it in the demos dir.
PrasadG193
reviewed
Sep 22, 2020
| @@ -33,7 +33,7 @@ main() { | |||
| pkgs=( "$@" ) | |||
| fi | |||
| # -F matches for exact words, not regular expression (-E), that is what required here | |||
| grep -F "${prev}" -r "${pkgs[@]}" | cut -d ':' -f 1 | uniq | xargs sed -ri "s/${prev}/${next//./\\.}/g" | |||
| grep -F "${prev}" -Ir "${pkgs[@]}" --exclude-dir={mod,bin} | cut -d ':' -f 1 | uniq | xargs sed -ri "s/${prev}/${next//./\\.}/g" | |||
There was a problem hiding this comment.
What is the significance of -I option? Does that include binaries also?
There was a problem hiding this comment.
I is to exclude binary files.
PrasadG193
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
We ran the bump version script against specific dirs
which is not ideal, there are chances that some
files that we dont know of have these versions.
Now we just ignore mod,bin dirs and binary files
and running the script on the entire K10 repo.
We already introduced the issue by not running it
in the demos dir.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan