Change regex that matches the restic stats cmd op #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`restic stats` returned the output in below format
```
repository 8b4484dd opened successfully, password is correct
created new cache in /root/.cache/restic
scanning...
Stats for all snapshots in raw-data mode:
Total Blob Count: 194
Total Size: 1.786 MiB
```
but after release of kanister `0.49.0` we upgraded restic to
version 0.11.0 and after the output of `restic stats` has been
changed to
```
repository 5cbbd926 opened successfully, password is correct
created new cache in /root/.cache/restic
scanning...
Stats in raw-data mode:
Snapshots processed: 1
Total Blob Count: 194
Total Size: 1.786 MiB
```
This PR changes the regex that matched the line to figure
out the stats mode.
chaitanya-baraskar
pushed a commit
to chaitanya-baraskar/kanister
that referenced
this pull request
Apr 5, 2021
`restic stats` returned the output in below format
```
repository 8b4484dd opened successfully, password is correct
created new cache in /root/.cache/restic
scanning...
Stats for all snapshots in raw-data mode:
Total Blob Count: 194
Total Size: 1.786 MiB
```
but after release of kanister `0.49.0` we upgraded restic to
version 0.11.0 and after the output of `restic stats` has been
changed to
```
repository 5cbbd926 opened successfully, password is correct
created new cache in /root/.cache/restic
scanning...
Stats in raw-data mode:
Snapshots processed: 1
Total Blob Count: 194
Total Size: 1.786 MiB
```
This PR changes the regex that matched the line to figure
out the stats mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
restic statsreturned the output in below formatbut after release of kanister
0.49.0as part of this PR (#826)we upgraded restic to version 0.11.0 and after the output of
restic statshas beenchanged to
This PR changes the regex that matched the line to figure
out the stats mode.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
DataSuite.TestDescribeBackupsthat was failingthe logs can be found here.
ResticDataSuitethe logs can be found here.