Add kopia server connect helper methods #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good overall. We may have to see if the changes to repository in the latest kopia master would require changes to this. We can merge and follow up. |
PrasadG193
commented
Jan 29, 2021
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
force-pushed
the
kopia-connect
branch
from
9136182
to
ba2b608
Compare
pavannd1
approved these changes
Feb 3, 2021
|
@PrasadG193 let's queue this behind #869 if possible. Some API changes would be required when we update Kopia |
|
@PrasadG193 The other PR merged. Please update the helpers accordingly |
pavannd1
reviewed
Feb 5, 2021
chaitanya-baraskar
pushed a commit
to chaitanya-baraskar/kanister
that referenced
this pull request
Apr 5, 2021
* Add kopia server connect helper methods Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Add licence headers Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Update connect options Co-authored-by: Pavan Navarathna <pavan@kasten.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prasad Ghangal prasad.ghangal@gmail.com
Change Overview
New pkg kopia with kopia server connect helper methods
Pull request type
Please check the type of change your PR introduces:
Test Plan
Will wait for server side implementation for the e2e testing