Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resources field to PodOptions to allow resource configuration #897

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

ankitjain235
Copy link
Contributor

@ankitjain235 ankitjain235 commented Feb 10, 2021

Change Overview

This PR adds Resource field to PodOptions so that pods can be configured with resource requests and limits.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@pavannd1 pavannd1 marked this pull request as ready for review February 10, 2021 20:57
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add unit test for this in pod_test.go?
Looks good otherwise

Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 added the kueue label Feb 11, 2021
@mergify mergify bot merged commit 2d1564c into master Feb 11, 2021
@mergify mergify bot deleted the add-resources-podoptions branch February 11, 2021 20:27
chaitanya-baraskar pushed a commit to chaitanya-baraskar/kanister that referenced this pull request Apr 5, 2021
…nisterio#897)

* Add Resources field to PodOptions to allow resource requirements to be set

* Add test for PodOptions.Resources

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants