Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kopia location profile #948

Merged
merged 11 commits into from
Apr 22, 2021
Merged

Add support for Kopia location profile #948

merged 11 commits into from
Apr 22, 2021

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Apr 7, 2021 •
edited
Loading

Change Overview

  • Add new Location and Credential type - kopia
  • Add a way to pass connection info and creds to connect to Kopia server through Profile for kando operations

Depends on: #944

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

pavannd1
pavannd1 reviewed Apr 7, 2021
View reviewed changes
pkg/apis/cr/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/cr/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/param/param.go Outdated Show resolved Hide resolved
pavannd1 and others added 4 commits April 12, 2021 17:34
@pavannd1 @PrasadG193
Remove unused code from package
6afc957
@pavannd1 @PrasadG193
More refactoring
24c3d65
@PrasadG193
Pass kopia server info through profiles
58ec5bf 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193
Extract cert fingerprint from plain cert
5535243 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193
Make kopia profile fields consistent with params
a97e224 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
pavannd1
pavannd1 reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

pkg/apis/cr/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/cr/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/param/param.go Outdated Show resolved Hide resolved
pkg/apis/cr/v1alpha1/types.go Show resolved Hide resolved
pkg/param/param.go Outdated Show resolved Hide resolved
pkg/param/param.go Outdated Show resolved Hide resolved
pkg/param/param.go Outdated Show resolved Hide resolved
pkg/param/param.go Outdated Show resolved Hide resolved
pkg/param/param.go Show resolved Hide resolved
@PrasadG193
Fix json tags
737ae86 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
pavannd1
pavannd1 reviewed Apr 19, 2021
View reviewed changes
pkg/kando/location_pull.go Outdated Show resolved Hide resolved
pkg/kando/location_push.go Outdated Show resolved Hide resolved
@PrasadG193
Don't handle Kopia location
b4c9da8 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193
Happy lint
1cacf65 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 mentioned this pull request Apr 19, 2021
Merged
10 tasks
pavannd1
pavannd1 reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

pkg/kando/location_pull.go Outdated Show resolved Hide resolved
pkg/kando/location_pull.go Outdated Show resolved Hide resolved
@PrasadG193
Remove debug logs in connectToKopiaServer
ed61143 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 mentioned this pull request Apr 20, 2021
Merged
10 tasks
@PrasadG193
Add support for kando location delete for kopia loc (#954)
fe8417c 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@mergify mergify bot merged commit 248b888 into master Apr 22, 2021
@mergify mergify bot deleted the kopia-profile branch April 22, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@tdmanv tdmanv Awaiting requested review from tdmanv

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrasadG193 @pavannd1