Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce parallelism of integration test for kanister apps #988

Merged
merged 11 commits into from
May 13, 2021
Merged

Reduce parallelism of integration test for kanister apps #988

merged 11 commits into from
May 13, 2021

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented May 11, 2021 •
edited
Loading

Change Overview

This PR fixes the flaking issue in the Integration test with the elastic search applications. Helm Chart for ElasticSearch fails to install on kansiter CI. We have reduced the parallelism of the integration test for apps from 8 to 4.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@viveksinghggits
Copy link
Contributor

@A-kanksh-a
I don't think we want to get this in yet, let me know once you are confident that we should get this in.

@akankshakumari393
Copy link
Contributor Author

yeah @viveksinghggits you're right. I am still trying some changes on CI. I will mark this as ready for review once done.

@akankshakumari393 akankshakumari393 changed the title added helm flag values extraInitContainer for elasticSearch Reduce parallelism of integration test for kanister apps May 12, 2021
@akankshakumari393 akankshakumari393 marked this pull request as ready for review May 12, 2021 13:25
PrasadG193
PrasadG193 approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed due to docker rate-limiting, retriggered

@mergify mergify bot merged commit 788ab6d into master May 13, 2021
@mergify mergify bot deleted the fix_elasticsearch branch May 13, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akankshakumari393 @viveksinghggits @pavannd1 @PrasadG193