-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme selector and dark theme #100
Conversation
It is necessary to correct some flaws in the themes |
@rurigk It's an interesting feature. |
Take the other configurations as an example |
The only problem I saw when implementing it is that when you put an empty theme (Default) you lose styles of some elements The dark theme is based on the subject of obs-studio with some small modifications |
@rurigk In each ui file, some widgets customize their style sheets. If you change the overall display in the theme feature, you will need to be careful not to contradict it. By the way, when I tried to build your repository, it seems that the symbol defined by Qt-5.12 called QPalette::PlaceholderText is used. I want to guarantee that I can build with Qt-5.9 for the time being, is it possible to fix your patch? |
I will try to compile it in that version of qt And for the styles, I think we can migrate the styles that are in the ui files to the themes |
I could not make it work in my version of Qt Creator 4.8.2 with Qt 5.9 https://bugreports.qt.io/browse/QTBUG-72555 Could you try replacing optionsdialog.ui with the version of your branch and adding a combobox called comboBoxThemeSelector with "Default" and "Dark" items? |
I confirmed that I can build at least qt-5.11 except where I pointed out, so I accept it once. I will fix it myself later. Thanks! |
I only added a theme selector and a dark theme
Themes are loaded from a resource file
I forgot to put it as draft