feature: only do collision check when needed (#314)

kaplayjs · Aug 4, 2024 · 15e9992 · 15e9992
1 parent de4ff16
commit 15e9992
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 8 deletions.
diff --git a/src/components/physics/area.ts b/src/components/physics/area.ts
@@ -18,6 +18,12 @@ import type { AnchorComp } from "../transform/anchor";
 import type { FixedComp } from "../transform/fixed";
 import type { PosComp } from "../transform/pos";
 
+let areaCount = 0;
+
+export function usesArea() {
+    return areaCount > 0;
+}
+
 /**
  * The {@link area `area()`} component.
  *
@@ -217,6 +223,7 @@ export function area(opt: AreaCompOpt = {}): AreaComp {
         collisionIgnore: opt.collisionIgnore ?? [],
 
         add(this: GameObj<AreaComp>) {
+            areaCount++;
             if (this.area.cursor) {
                 this.onHover(() => app.setCursor(this.area.cursor!));
             }
@@ -237,6 +244,10 @@ export function area(opt: AreaCompOpt = {}): AreaComp {
             });
         },
 
+        destroy() {
+            areaCount--;
+        },
+
         update(this: GameObj<AreaComp>) {
             for (const id in colliding) {
                 if (!collidingThisFrame.has(Number(id))) {
@@ -407,9 +418,11 @@ export function area(opt: AreaCompOpt = {}): AreaComp {
                     }
                 });
             }
-            else {throw new Error(
+            else {
+                throw new Error(
                     "onCollide() requires either a function or a tag",
-                );}
+                );
+            }
         },
 
         onCollideUpdate(
@@ -426,9 +439,11 @@ export function area(opt: AreaCompOpt = {}): AreaComp {
                     (obj, col) => obj.is(tag) && cb?.(obj, col),
                 );
             }
-            else {throw new Error(
+            else {
+                throw new Error(
                     "onCollideUpdate() requires either a function or a tag",
-                );}
+                );
+            }
         },
 
         onCollideEnd(
@@ -445,9 +460,11 @@ export function area(opt: AreaCompOpt = {}): AreaComp {
                     (obj) => obj.is(tag) && cb?.(obj),
                 );
             }
-            else {throw new Error(
+            else {
+                throw new Error(
                     "onCollideEnd() requires either a function or a tag",
-                );}
+                );
+            }
         },
 
         hasPoint(pt: Vec2): boolean {
@@ -517,9 +534,11 @@ export function area(opt: AreaCompOpt = {}): AreaComp {
             if (this.area.scale.x == this.area.scale.y) {
                 return `area: ${this.area.scale.x.toFixed(1)}x`;
             }
-            else {return `area: (${this.area.scale.x.toFixed(1)}x, ${
+            else {
+                return `area: (${this.area.scale.x.toFixed(1)}x, ${
                     this.area.scale.y.toFixed(1)
-                }y)`;}
+                }y)`;
+            }
         },
     };
 }
diff --git a/src/kaplay.ts b/src/kaplay.ts
@@ -213,6 +213,7 @@ import {
     textInput,
     tile,
     timer,
+    usesArea,
     uvquad,
     z,
 } from "./components";
@@ -743,6 +744,10 @@ const kaplay = <
     }
 
     function checkFrame() {
+        if (!usesArea()) {
+            return;
+        }
+
         // TODO: persistent grid?
         // start a spatial hash grid for more efficient collision detection
         const grid: Record<number, Record<number, GameObj<AreaComp>[]>> = {};