Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-added missing examples #162

Merged
merged 1 commit into from
Jun 21, 2024
Merged

chore: re-added missing examples #162

merged 1 commit into from
Jun 21, 2024

Conversation

amyspark-ng
Copy link
Contributor

not sure if i had to add ALL of them or only the ones that were before

@amyspark-ng amyspark-ng marked this pull request as ready for review June 20, 2024 15:07
niceEli
niceEli approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@niceEli niceEli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻, i will say this is going to make test passing take longer tho.

@niceEli niceEli merged commit e2849c0 into kaplayjs:master Jun 21, 2024
1 check passed
@amyspark-ng
Copy link
Contributor Author

well it's fair since they were bound to be added and are good

@amyspark-ng amyspark-ng deleted the amy-chore-readd-missing-examples branch June 24, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niceEli niceEli niceEli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyspark-ng @niceEli