Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: faster tests #163

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat: faster tests #163

merged 1 commit into from
Jun 21, 2024

Conversation

niceEli
Copy link
Member

@niceEli niceEli commented Jun 21, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes if needed, a note
on the devices and browsers this has been tested on.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

test cases gif

@niceEli niceEli added the enhancement New feature or request label Jun 21, 2024
@niceEli niceEli requested review from mflerackers and lajbel June 21, 2024 01:46
@niceEli
Copy link
Member Author

niceEli commented Jun 21, 2024

the gif didnt work :(

Copy link
Member

@mflerackers mflerackers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@niceEli niceEli added CI Does this edit an action (tbh only me @niceEli prob gonna use this) (nop me @lajbel will use it too) and removed enhancement New feature or request labels Jun 21, 2024
@niceEli niceEli merged commit 5d2af25 into master Jun 21, 2024
2 checks passed
@lajbel lajbel deleted the niceEli-feat-testCases branch July 7, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Does this edit an action (tbh only me @niceEli prob gonna use this) (nop me @lajbel will use it too)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants