New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preview lyric not change the size if size changed. #2275

Merged

andy840119 merged 4 commits into karaoke-dev:master from andy840119:fix-preview-lyric-not-change-the-size-if-size-changed

Aug 19, 2024

Member

andy840119 commented Aug 19, 2024

What's done in this PR:

Should re-draw the interactable lyric if change the skin's font size.
Add key for increase/decrease the preview font size.
Click the button and handle the keyboard event should did the same things(trigger the action).
Change size button should inherit the ToolbarEditActionButton.

andy840119 added 4 commits

August 18, 2024 20:00


          Should re-draw the interactable lyric if change the skin's font size.

5d171cd


          Add key for increase/decrease the preview font size.

f8b2f65


          Click the button and handle the keyboard event should did the same th…

d8758eb

…ings(trigger the action).


          Change size button should inherit the ToolbarEditActionButton.

78282f9

andy840119 added bug code quality LyricMaker labels

andy840119 added this to the 2024.0831 milestone

pull-request-size bot added the size/L label

andy840119 merged commit f0a82b3 into karaoke-dev:master

4 checks passed

andy840119 deleted the fix-preview-lyric-not-change-the-size-if-size-changed branch

August 19, 2024 14:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug code quality LyricMaker size/L