-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screenshot comparison capability #2141
Comments
@jkeys089 we are very open to the idea. if I understand you right, the pure Java image comparison routines are written from scratch, which sounds really good. one question is how much does this add to the maven dependencies. depending on that - we can take a call if this has to be part of the main karate project, or even within really appreciate your work on this. |
@ptrthomas great! Yes, the image comparison code is ported from Javascript to Java by hand and adds no new dependencies. It may make sense to split those out as separate projects and then pull them in as dependencies. For the report UI we added two additional dependencies: Resemble.js and jQuery UI (used for dragging / resizing ignored boxes) It will take us a bit of work to clean everything up and remove bits that are specific to our needs. I guess the initial PR should be ready in a week or two once we get started. |
@jkeys089 looking forward to it ! the JS dependencies sound good to me, we currently bundle a few including jQuery |
1.3.0 released |
The purpose of this issue is to start a conversation about wether or not you might be interested in a contribution of a new UI testing capability: screenshot comparison.
We've built a screenshot comparison feature that we've been using internally with good results for a while. We actually started with a commercial service (https://percy.io/) and then migrated to an OSS project running locally (https://github.com/Mikuu/Micoo) for a bit more control. After running into a few issues we realized we needed something integrated with Karate and we built one.
Some of the issues we encountered using external screenshot comparison services include:
Our ideal solution:
We accomplished our goals by:
diffImg
function that accepts a named image and a baseline screenshot directory along with an optional configurationMy question is: would you be interested in accepting this feature into the main Karate project or would it be better to keep this as a separate project?
If you're interested, we'd be happy to contribute the feature and collaborate with the Karate team to ensure it fits naturally.
The text was updated successfully, but these errors were encountered: