feat(run): Allow zip path as first argument #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow usage with other zip files.
- created minimal in memory cache implementation - `contentLoader` is no longer responsible for storing the value, since it doesn't know the key - added `entriesLoader.CACHE` so it also impacts reading entries from other zip files. - `xmltest.json` is now only required as part of `getEntries`, not when the module is loaded. It's also the only method that uses the the entries. - Extracted and simplified type for `Entries` so it's no longer tied to the keys in `xmltest.json`
when using without file argument. (If run would use `entries`, we would not be able to update the file with `runex ./xmltest.js > xmltest.json`.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to allow usage with other zip files.
contentLoaderandentriesLoadercachexmltest.jsonis now only required as part ofgetEntries, not when the module is loaded. It's also the only method that uses those entries.runmethod