-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronized Sync (Mode 2026) #576
Conversation
@karlstav Tested in ghostty, alacritty, kitty, and gnome console. This is a naive implementation but it does seem to work. |
d81c2c2
to
24d8205
Compare
sorry for the late feedback. There is one thing I don't understand. Why is there both a begin and end update before and after the draw function? Shouldn't there be BSU (2026h) before (line 1101) and ESU (2026l) after (line 1152)? |
To be honest, this was a very naive implementation -- I did it to the point where it worked, but I think that I probably made a mistake or two along the way. I am not a C programmer nor a terminal UI programmer, but this fixed works for me, although I doubt it's the right way to do things. Something about having the update go through even though it immediately gets ended makes ghostty not tear. I think it could probably work as you described having the BSU before and the ESU after. Feel free to change my implementation! |
If it works, it works. A couple of things though: if the old alacritty sync thing has not been deprecated by alacritty i think we should keep it along side this one. Also I think this sync method also must be a config option and that it must be default off. Never know if it can cause issues. |
Afaik alacritty now uses the new standard. Tested this on kitty/ghostty/alactitty/foot and all worked |
noted, alacritty/alacritty#7365 just re apply the config option (I still believe it should be optional) and squash the commits and then I can merge |
Should hopefully be able to do soon :D |
Oh shit I kinda forgot about this |
@karlstav there we go! Sorry about the very long delay |
Tested properly now. Works completely as expected! |
no problem, hmm looks like I can squash the commits when i merge, i did not know that. seemed excessive with 10 commits for the 5 lines of code change. |
Deprecates the Alacritty synchronization option for Mode 2026 (https://gist.github.com/christianparpart/d8a62cc1ab659194337d73e399004036)