-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semver and peerdependencies #5
Comments
Adding this to all plugins should resolve the issue for the new versions: "peerDependencies": {
"karma": ">=0.9.0 || >=0.13.0-rc.0"
} Edit: Not working as the above does not match |
@dignifiedquire what about remove |
@maksimr I'm getting the feeling that removing it is the best way forward |
After some more contemplation and references like npm/npm#5080 I think the way forward should be:
If I don't hear any arguments against this, I will make the needed prs/changes starting tomorrow // cc @karma-runner/contributors |
For discussion and reasoning see karma-runner/integration-tests#5.
For discussion and reasoning see karma-runner/integration-tests#5.
For discussion and reasoning see karma-runner/integration-tests#5.
For discussion and reasoning see karma-runner/integration-tests#5.
This avoids a lot of issues we are having with peerDependencies. BREAKING CHANGE: Karma is no longer a `peerDependency` so it needs to be installed manually. Ref karma-runner/integration-tests#5
After I started using proper semver versions for the canary releases currently integration tests are broken for the canary branch :(
The issue is that
>= 0.12.0
does not include a version like0.13.0-rc.0
as it only uses stable versions. Any ideas or thoughts on how to best fix this?cc @karma-runner/contributors
Update
Removing all peerDependencies as describe below:
External
The text was updated successfully, but these errors were encountered: