-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only specifying some types of watermarks results in an error #144
Comments
nmalaguti
added a commit
to nmalaguti/karma-coverage
that referenced
this issue
Apr 14, 2015
Merges in specified watermarks with the Istanbul defaults. Closes karma-runner#144
nmalaguti
added a commit
to nmalaguti/karma-coverage
that referenced
this issue
Jun 1, 2015
Merges the coverageReporter config with the options passed to each reporter. Merges in specified watermarks with the Istanbul defaults. Added tests for watermarks Closes karma-runner#143, karma-runner#144
@nmalaguti can this be closed now that #145 is merged? |
Yes. Resolved by #145. |
This was referenced Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is blocked by issue #143.
Specifying only
statements
andlines
results in an error from Istanbul.This appears to be because Istanbul expects the
watermarks
object to have all 4 types specified. I'm not sure if this is an issue with Istanbul or if karma-coverage should merge any specifiedwatermarks
with a set of defaults.From https://github.com/gotwarlost/istanbul/blob/master/lib/report/common/defaults.js:
The text was updated successfully, but these errors were encountered: