Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reporter allow using a externally provided source cachere for reporters #140

Conversation

weikinhuang
Copy link
Contributor

change coverageReporter options to allow for specifying sourceStore, this
is an instance of istanbul.Store to look up source files. This allows using
external coverage collectors like browserify-istanbul for instrumenting code.

references #16, #123, #124

@weikinhuang
Copy link
Contributor Author

This pull request allows for specifying an external source cache storage in karma.conf.js

module.exports = function(config) {
  config.set({

    coverageReporter: {
      type: "html",
      sourceStore: require("istanbul").Store.create("fslookup")
    }

}

@weikinhuang
Copy link
Contributor Author

also, can someone take a look as to why the travis build failed?

@vperron
Copy link

vperron commented May 21, 2015

did it ?

@dignifiedquire
Copy link
Member

Travis looks happy, but this needs a rebase onto the latest master, as there are merge conflicts

@weikinhuang weikinhuang force-pushed the fix-browserify-istanbul-reports branch from f7f8957 to ec67e37 Compare May 21, 2015 14:26
@weikinhuang
Copy link
Contributor Author

rebased

@dignifiedquire
Copy link
Member

Could you add some documentation about this please?

@weikinhuang
Copy link
Contributor Author

sure

@dignifiedquire
Copy link
Member

stilll missing docs and rebase

@weikinhuang weikinhuang force-pushed the fix-browserify-istanbul-reports branch from ec67e37 to d0e45b9 Compare June 9, 2015 14:05
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@weikinhuang
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

lib/reporter.js 100644 → 100755 looks like you accidentally change the file permissions for lib/reporter could you revert that please?

@weikinhuang weikinhuang force-pushed the fix-browserify-istanbul-reports branch from d0e45b9 to 39a6ae0 Compare June 9, 2015 14:20
@weikinhuang
Copy link
Contributor Author

fixed

@dignifiedquire
Copy link
Member

@weikinhuang I'm afraid I need another rebase, another merge conflict while I merged a different PR, thanks

…porters

change `coverageReporter` options to allow for specifying `sourceStore`, this
is an instance of `istanbul.Store` to look up source files. This allows using
external coverage collectors like `browserify-istanbul` for instrumenting code.
@weikinhuang weikinhuang force-pushed the fix-browserify-istanbul-reports branch from 39a6ae0 to 9b1517f Compare June 9, 2015 14:58
@weikinhuang
Copy link
Contributor Author

rebased

@dignifiedquire
Copy link
Member

Thanks

dignifiedquire added a commit that referenced this pull request Jun 9, 2015
fix: reporter allow using a externally provided source cachere for reporters
@dignifiedquire dignifiedquire merged commit 1393291 into karma-runner:master Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants