fix: Karma reported test duration is negative fix #143

karma-runner · Nov 29, 2016 · 93452bb · 93452bb
1 parent ecd289e
commit 93452bb
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/src/adapter.js b/src/adapter.js
@@ -158,6 +158,10 @@ function getAllSpecNames (topSuite) {
 function KarmaReporter (tc, jasmineEnv) {
   var currentSuite = new SuiteNode()
 
+  // Save link on native Date object
+  // because user can mock it
+  var _Date = Date
+
   /**
    * @param suite
    * @returns {boolean} Return true if it is system jasmine top level suite
@@ -208,7 +212,7 @@ function KarmaReporter (tc, jasmineEnv) {
   }
 
   this.specStarted = function (specResult) {
-    specResult.startTime = new Date().getTime()
+    specResult.startTime = new _Date().getTime()
   }
 
   this.specDone = function (specResult) {
@@ -223,7 +227,7 @@ function KarmaReporter (tc, jasmineEnv) {
       pending: specResult.status === 'pending',
       success: specResult.failedExpectations.length === 0,
       suite: [],
-      time: skipped ? 0 : new Date().getTime() - specResult.startTime,
+      time: skipped ? 0 : new _Date().getTime() - specResult.startTime,
       executedExpectationsCount: specResult.failedExpectations.length + specResult.passedExpectations.length
     }
 

diff --git a/test/adapter.spec.js b/test/adapter.spec.js
@@ -247,6 +247,23 @@ describe('jasmine adapter', function () {
 
       expect(karma.result).toHaveBeenCalled()
     })
+
+    describe('time', function () {
+      afterEach(function () {
+        jasmine.clock().uninstall()
+      })
+
+      it('should report correct time if user mock Date object', function () {
+        karma.result.and.callFake(function (result) {
+          expect(result.time >= 0).toBe(true)
+        })
+
+        reporter.specStarted(spec.result)
+
+        jasmine.clock().mockDate(new Date(0))
+        reporter.specDone(spec.result)
+      })
+    })
   })
 
   describe('formatFailedStep', function () {