Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if no outputFile defined (regression in v0.4.0) #87

Closed
carljm opened this issue Mar 10, 2016 · 0 comments
Closed

Error if no outputFile defined (regression in v0.4.0) #87

carljm opened this issue Mar 10, 2016 · 0 comments
Labels
PR please priority: high type: bug

Comments

@carljm
Copy link

carljm commented Mar 10, 2016

Recent commit d5dc808 causes karma-junit-reporter to no longer function if an outputFile is not defined in the config, even though outputFile is documented as optional and was previously optional. The error is TypeError: Cannot read property 'charAt' of undefined, and it's caused by calling pathIsAbsolute(outputFile) in writeXmlForBrowser without first checking to make sure outputFile was set.
carljm referenced this issue Mar 10, 2016
@vermeeca
fix: Handle absolute outputFile paths in Junit Reporter
d5dc808 
Modifies the Junit Reporter so that it doesn't try to combine the output directory path and the output file, if the output file is already an absolute path

Closes #83
matthauck added a commit to matthauck/karma-junit-reporter that referenced this issue Mar 11, 2016
@matthauck
Fix karma-runner#87: Do not break when no outputFile is set
3276985
@cloakedninjas cloakedninjas mentioned this issue Mar 11, 2016
Closed
@vermeeca vermeeca mentioned this issue Mar 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR please priority: high type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carljm @dignifiedquire