Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

Chore/align node support same as karma - fix current failing CI #210

Merged

Conversation

elpddev
Copy link
Contributor

@elpddev elpddev commented Jul 17, 2019

Reason

Current travisci builds are failing for:

  1. node < 6, npm update of npm tries to install npm version 6 that does not support node <= 4.
9.74s$ npm install -g npm
/home/travis/.nvm/versions/node/v4.9.1/bin/npm -> /home/travis/.nvm/versions/node/v4.9.1/lib/node_modules/npm/bin/npm-cli.js
/home/travis/.nvm/versions/node/v4.9.1/bin/npx -> /home/travis/.nvm/versions/node/v4.9.1/lib/node_modules/npm/bin/npx-cli.js
npm@6.9.0 /home/travis/.nvm/versions/node/v4.9.1/lib/node_modules/npm
/home/travis/.nvm/versions/node/v4.9.1/lib/node_modules/npm/bin/npm-cli.js:84
      let notifier = require('update-notifier')({pkg})
      ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
  1. node stable (12), mock-fs old version support node up until version 7 and emit support error.
$ npm run test:lib
> karma-mocha@1.3.0 test:lib /home/travis/build/karma-runner/karma-mocha
> mocha test/lib
/home/travis/build/karma-runner/karma-mocha/node_modules/mock-fs/lib/index.js:38
  throw new Error('Unsupported Node version: ' + nodeVersion);
  ^
Error: Unsupported Node version: 12.2.0
    at Object.<anonymous> (/home/travis/build/karma-runner/karma-mocha/node_modules/mock-fs/lib/index.js:38:9)

Current karma travis ci is configured for node 8 and 10 testing.

Solution

  • Change CI to check only node 8 and 10
  • Update mock-fs library to support node > 7

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@elpddev
Copy link
Contributor Author

elpddev commented Jul 17, 2019

I signed it!

@johnjbarton johnjbarton merged commit c8feade into karma-runner:master Jul 17, 2019
@elpddev elpddev deleted the chore/align-node-support-same-as-karma branch July 18, 2019 05:49
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants