-
Notifications
You must be signed in to change notification settings - Fork 95
update minimist dependency to require a minimum version of 1.2.3 #216
Conversation
BREAKING CHANGE: drop support for node 8
This addresses https://npmjs.com/advisories/1179, specifically #214
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Fix travis build
Update node versions
I guess you need to rebase on master to trigger tests on node 10 + 12. |
@johnjbarton I'm not too familiar yet with the processes. Can you elaborate on what I need to do? What I have done so far:
Does this describe what I need to do? |
Those instructions are ok but overkill.
That leaves you with your commit on minimist-update and master with no extra commits.
Now your master matches upstream master
Now you have a new PR to create on github. You might be able to do this without the branch but this is the workflow I know. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Will try to do the rebasing thingy @johnjbarton suggested. |
@johnjbarton I've succesfully completed a rebased version of the PR: #217 Thanks for your help. |
Sorry for commenting to a closed pull request. But can somebody create a release including the latest changed, please? |
This addresses https://npmjs.com/advisories/1179, specifically #214