Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captureTimeout should start after a browser is granted #37

Closed
vojtajina opened this issue Apr 30, 2014 · 7 comments
Closed

captureTimeout should start after a browser is granted #37

vojtajina opened this issue Apr 30, 2014 · 7 comments

Comments

@vojtajina
Copy link
Contributor

Most of the time it gets timeouted on just waiting for a browser, not actual problem.

vojtajina added a commit to angular/angular.js that referenced this issue Apr 30, 2014
All of the recent failures were caused by too much load on SL, not
an actual problem.

I think a proper solution will be:
karma-runner/karma-sauce-launcher#37
stickel pushed a commit to stickel/angular.js that referenced this issue May 1, 2014
All of the recent failures were caused by too much load on SL, not
an actual problem.

I think a proper solution will be:
karma-runner/karma-sauce-launcher#37
@ChrisWren
Copy link
Contributor

@vojtajina any idea how to do this? It looks like it has to interface with the karma internals: https://github.com/karma-runner/karma-sauce-launcher/blob/master/lib/sauce_launcher.js#L8

@ChrisWren
Copy link
Contributor

Might be a matter of moving captureTimeoutLauncherDecorator(this); to somewhere else in the launcher. I tried moving it to the start function, but it never started...

@Krinkle
Copy link

Krinkle commented Jul 18, 2014

Might be related to #40.

@pkozlowski-opensource
Copy link
Member

@ChrisWren moving the captureTimeoutLauncherDecorator(this); to the start method won't do the trick as the captureTimeout starts only on the start event: https://github.com/karma-runner/karma/blob/51f1b8832b86c4f556b58381fa183776212cfaa7/lib/launchers/capture_timeout.js#L14
But when we are in the start method the start event was already fired.

I tend to think that we need to:

  • add another method to the captureTimeoutLauncherDecorator - something like startTimer or sth.
  • add another config option (autoStartCaptureTimer)

and then start a capture timer "manually" from the Sauce launcher (this way we could choose the exact moment, ex.: after a WD session is ready).

@vojtajina @ChrisWren does it sound like a sensible solution?

@mightyiam
Copy link

🐱

@JamesMGreene
Copy link

Any update, PR, or merged/equivalent implementation?

@wswebcreation
Copy link
Collaborator

Closing this due to inactivity, feel free to re-open if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants