fix(middleware): catch errors when loading a module (#3605)

Fix #3572 Co-authored-by: https://github.com/jehon
karma-runner · Jan 12, 2021 · fec972f · fec972f
1 parent 3fca456
commit fec972f
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/lib/middleware/karma.js b/lib/middleware/karma.js
@@ -191,7 +191,11 @@ function createKarmaMiddleware (
             } else {
               const scriptType = (SCRIPT_TYPE[fileType] || 'text/javascript')
               const crossOriginAttribute = includeCrossOriginAttribute ? 'crossorigin="anonymous"' : ''
-              scriptTags.push(`<script type="${scriptType}" src="${filePath}" ${crossOriginAttribute}></script>`)
+              if (fileType === 'module') {
+                scriptTags.push(`<script onerror="throw 'Error loading ${filePath}'" type="${scriptType}" src="${filePath}" ${crossOriginAttribute}></script>`)
+              } else {
+                scriptTags.push(`<script type="${scriptType}" src="${filePath}" ${crossOriginAttribute}></script>`)
+              }
             }
           }
 

diff --git a/test/e2e/error.feature b/test/e2e/error.feature
@@ -40,3 +40,19 @@ Feature: Error Display
       """
       SyntaxError: Unexpected token '}'
       """
+
+Scenario: Missing module Error in a test file
+    Given a configuration with:
+      """
+      files = [{pattern: 'error/import-something-from-somewhere.js', type: 'module'}];
+      browsers = ['ChromeHeadlessNoSandbox'];
+      plugins = [
+        'karma-jasmine',
+        'karma-chrome-launcher'
+      ];
+      """
+    When I start Karma
+    Then it fails with:
+      """
+      Uncaught Error loading error/import-something-from-somewhere.js
+      """
diff --git a/test/e2e/support/error/import-something-from-somewhere.js b/test/e2e/support/error/import-something-from-somewhere.js
@@ -0,0 +1,2 @@
+import { something } from './somewhere.js'
+console.log(something)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		import { something } from './somewhere.js'
		console.log(something)