v6 CLI arg verification breaks extra args parsing #3625
Comments
|
We hit the same issue. I wonder if we can use |
|
@johnjbarton Good idea! We can both retain strict validation of Karma options and allow users to pass arbitrary custom options. The only concern is that we already use this feature for |
|
So I think the best solution would be to introduce |
|
This also broke the main feature of karma-jasmine-spec-tags, see their Issue 12. |
|
@paulie4 Thanks for sharing! Looking at this library I start to think that maybe we should provide an API for a plugin to register their CLI arguments. This way there will be one standard mechanism and as a bonus, we can include parameters provided by plugins in the The solution from #3625 (comment) will not work for karma-jasmine-spec-tags without extra changes on their side. At this point, I lean towards temporarily reverting the strict parameters validation and gathering more feedback on the custom parameter use cases. So we can design a mechanism, which works for everybody. |
|
Agree. Seems like a big change w/o some sort of RFC. |
As discussed in karma-runner#3625 there are multiple use cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments then are either handled in a `karma.conf.js` file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the change is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.
As discussed in karma-runner#3625 there are multiple cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments then are either handled in a `karma.conf.js` file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the change is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.
As discussed in karma-runner#3625 there are multiple cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments are either handled in a `karma.conf.js` file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the feature is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.
|
karma-ui5 is another plugin which made use of the feature to pass CLI args to override config options (e.g. |
As discussed in #3625 there are multiple cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments are either handled in a `karma.conf.js` file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the feature is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.
## [6.0.4](v6.0.3...v6.0.4) (2021-02-01) ### Bug Fixes * **cli:** temporarily disable strict parameters validation ([#3641](#3641)) ([9c755e0](9c755e0)), closes [#3625](#3625) * **client:** fix a false positive page reload error in Safari ([#3643](#3643)) ([2a57b23](2a57b23)) * ensure that Karma supports running tests on IE 11 ([#3642](#3642)) ([dbd1943](dbd1943))
…ner#3641) As discussed in karma-runner#3625 there are multiple cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments are either handled in a `karma.conf.js` file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the feature is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.
## [6.0.4](karma-runner/karma@v6.0.3...v6.0.4) (2021-02-01) ### Bug Fixes * **cli:** temporarily disable strict parameters validation ([karma-runner#3641](karma-runner#3641)) ([9c755e0](karma-runner@9c755e0)), closes [karma-runner#3625](karma-runner#3625) * **client:** fix a false positive page reload error in Safari ([karma-runner#3643](karma-runner#3643)) ([2a57b23](karma-runner@2a57b23)) * ensure that Karma supports running tests on IE 11 ([karma-runner#3642](karma-runner#3642)) ([dbd1943](karma-runner@dbd1943))
Hello, currently karma CLI doesn't allow explicit test files as arg so we're passing them at the end and parse them out in
karma.conf.jsand v6 breaks it so I'm essentially asking if:I understand that this is not previously a feature but a lot of stack overflow answers seem to point to this mechanism being the workaround to further modify karma conf using CLI arg.
The way we're calling it is essentially
karma start karma.conf.js [testFiles...]Thanks!
The text was updated successfully, but these errors were encountered: