Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preprocessor): Capital letters in binary files extenstions #1509

Conversation

lonelyelk
Copy link
Contributor

Use lower case file extension to detect if it is binary

Closes #1508

Use lower case file extension to detect if it is binary

Closes karma-runner#1508
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@lonelyelk
Copy link
Contributor Author

I signed it!

On Wed, Jul 22, 2015 at 12:38 AM, googlebot notifications@github.com
wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#1509 (comment).

@googlebot
Copy link

CLAs look good, thanks!

dignifiedquire added a commit that referenced this pull request Jul 22, 2015
…nary-file-extensions

feat(preprocessor): Capital letters in binary files extenstions
@dignifiedquire dignifiedquire merged commit a1c1cb0 into karma-runner:master Jul 22, 2015
@dignifiedquire
Copy link
Member

Thanks :octocat:

@dignifiedquire
Copy link
Member

Published in 0.13.3

@lonelyelk
Copy link
Contributor Author

Yay! Even released! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants