Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for custom context and/or debug html files #1586

Closed
wants to merge 1 commit into from
Closed

feat: Support for custom context and/or debug html files #1586

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 16, 2015

This is a replacement for the pull request #1360. I have updated the code for the latest master. There was also a bug in the old pull request code because requestUrl was overwritten. I have also added support for absolute paths.

@GitCop
Copy link

GitCop commented Sep 16, 2015

There were the following issues with your Pull Request

  • Commit: 94824e8
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@ghost
Copy link
Author

ghost commented Sep 16, 2015

If you tell me the correct scope, I can add it to the commit message.

@dignifiedquire
Copy link
Member

You can leave the scope out that's okay, but this is still missing some stuff I mentioned in the other PR

  • update the docs so people can find these options
  • these options shouldn't be nested in the client configs, they should be top level and default to the ones karma brings
  • path normalization and setting defaults should be done in lib/config.js

@dignifiedquire
Copy link
Member

ping @sanjo

@ghost
Copy link
Author

ghost commented Jan 4, 2016

The changes that you wrote in #1586 (comment) still need to be done.

@dignifiedquire
Copy link
Member

Closing in favor of #1825

@durgesh-priyaranjan
Copy link

Is this change published to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants