Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (proxy): Pass protocol in target object to enable https requests. #1642

Merged
merged 1 commit into from
Oct 20, 2015

Conversation

doctyper
Copy link
Contributor

The protocol parameter is necessary to allow proxying of an HTTPS server.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@GitCop
Copy link

GitCop commented Oct 19, 2015

There were the following issues with your Pull Request

  • Commit: cc5ba96
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@doctyper doctyper changed the title Pass protocol in target object to enable https requests. fix (proxy): Pass protocol in target object to enable https requests. Oct 19, 2015
@doctyper
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks could you please

  • update the docs with the new config parameter,
  • add a test for this behaviour and
  • update the commit message to follow our guideline

@skoontz
Copy link

skoontz commented Oct 20, 2015

This looks like it might be why I'm getting errors because I'm using a proxy with https. Could you give me a quick example of using this config parameter? Thanks

@doctyper
Copy link
Contributor Author

@skoontz if you just use the proxy param as normal it will work with this patch, e.g.:

        proxies: {
            "/base": "https://example.com"
        },

@doctyper
Copy link
Contributor Author

@dignifiedquire the config parameter is already documented here.

@GitCop
Copy link

GitCop commented Oct 20, 2015

There were the following issues with your Pull Request

  • Commit: cc5ba96
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: 5ba127f
    • Commits must be in the following format: %{type}(%{scope}): %{description}
    • Your subject line is longer than 70 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

The protocol parameter is necessary to allow proxying of an HTTPS server.
@doctyper
Copy link
Contributor Author

@dignifiedquire Test added, commit message updated. Let me know if you need anything else.

doctyper pushed a commit to nfl/karma that referenced this pull request Oct 20, 2015
@dignifiedquire
Copy link
Member

Thanks :octocat:

dignifiedquire added a commit that referenced this pull request Oct 20, 2015
fix (proxy): Pass protocol in target object to enable https requests.
@dignifiedquire dignifiedquire merged commit b138619 into karma-runner:master Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants