-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (proxy): Pass protocol in target object to enable https requests. #1642
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
I signed it! |
CLAs look good, thanks! |
Thanks could you please
|
This looks like it might be why I'm getting errors because I'm using a proxy with https. Could you give me a quick example of using this config parameter? Thanks |
@skoontz if you just use the proxy param as normal it will work with this patch, e.g.: proxies: {
"/base": "https://example.com"
}, |
@dignifiedquire the config parameter is already documented here. |
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
5ba127f
to
73877fc
Compare
The protocol parameter is necessary to allow proxying of an HTTPS server.
73877fc
to
142db90
Compare
@dignifiedquire Test added, commit message updated. Let me know if you need anything else. |
Thanks |
fix (proxy): Pass protocol in target object to enable https requests.
The
protocol
parameter is necessary to allow proxying of an HTTPS server.