fix: ignore jsVersion configuration property in Firefox 59+ #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for specifying JavaScript version was removed in Firefox 59. See https://bugzilla.mozilla.org/show_bug.cgi?id=1428745 for more details. From now on Karma will ignore `jsVersion` property in Firefox 59+ and print deprecation warning if `jsVersion` property is found.
|
This should fix #2957 as soon as it works |
|
Broken build is because new release of karma-qunit broke one of the integration tests. Looks like https://github.com/karma-runner/integration-tests/blob/master/coverage-qunit/package.json should depend on Blocked on karma-runner/integration-tests#7 |
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for specifying JavaScript version was removed in Firefox 59. See
https://bugzilla.mozilla.org/show_bug.cgi?id=1428745 for more details.
From now on Karma will ignore
jsVersionproperty in Firefox 59+ andprint deprecation warning if
jsVersionproperty is set.